Implement multiple tiers caching with fallback and backfilling#2581
Implement multiple tiers caching with fallback and backfilling#2581Felixoid wants to merge 16 commits intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
==========================================
+ Coverage 73.38% 74.18% +0.80%
==========================================
Files 68 70 +2
Lines 37340 39208 +1868
==========================================
+ Hits 27402 29087 +1685
- Misses 9938 10121 +183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0a4503d to
e069c90
Compare
38af4ef to
b70bd73
Compare
22b9835 to
445e8b9
Compare
7e50b5c to
3b5cfe5
Compare
|
I've done quite a few features today, like control for write error handling, and added server stats for multilevel caching. |
|
this is a huge patch, can you split a bit more? thanks |
|
Probably I could take something out of |
3fe062e to
1dc75d4
Compare
|
Rebased to the current This PR now contains the multi-level cache feature exclusively. Most of the changes are the tests and documentation, which are around 70%. |
|
Hi @drahnr and @sylvestre , Is it OK for you? Can we merge these changes? |
|
Thanks a lot for the work here, just curious if SCCACHE_BASEDIRS is handled properly when using the multi-tier setup? |
|
i am not ignoring you. just higher priorities lately, sorry |
I don't have any specific tests for it, but I don't see how it could break. I'll try to add it too, just in case |
|
@sunnyguan thanks a lot for the spotlight, I indeed forgot to implement the |
fe2c7fa to
f590fb8
Compare
f590fb8 to
a24dc69
Compare
|
The merged #2649 caused a conflict. Resolved it by rebasing |
Cherry-picked from upstream PR mozilla#2581. Adds hierarchical cache storage (e.g., disk -> redis -> s3) with configurable write tolerance policies and automatic backfill from slower tiers to faster ones. Upstream: mozilla#2581 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cherry-picked from upstream PR mozilla#2581. Adds hierarchical cache storage (e.g., disk -> redis -> s3) with configurable write tolerance policies and automatic backfill from slower tiers to faster ones. Upstream: mozilla#2581 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This PR addresses multiple requests to have tiered caching.
Closes #30
Closes #1020
Closes #2493
Closes #2566
What is added: