WIP - working on cache-control changes for git-reader#1224
Draft
alexcottner wants to merge 4 commits intomainfrom
Draft
WIP - working on cache-control changes for git-reader#1224alexcottner wants to merge 4 commits intomainfrom
alexcottner wants to merge 4 commits intomainfrom
Conversation
leplatrem
reviewed
Mar 23, 2026
git-reader/app.py
Outdated
| settings: Settings = Depends(get_settings), | ||
| git: GitService = Depends(GitService.dep), | ||
| ): | ||
| response.headers["cache-control"] = f"max-age={settings.cache_control_short}" |
Contributor
There was a problem hiding this comment.
oh, that means we could potentially point the Push edges at the CDN 👀
Contributor
Author
There was a problem hiding this comment.
Absolutely. We could also shrink this one even further if we wanted to, like 30 or 15 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress, ignore for now...