Skip to content

Ctroy even more prints #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chelseatroy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ctroy even more prints #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf98f6
Hello from files
chelseatroy Sep 21, 2023
91b1f4e
Add a LOT of printing to the range check
chelseatroy Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions jobs/search-term-data-validation-v2/search_term_data_validation_v2/data_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
print("Hello from search_term_data_validation_v2/data_validation.py!")

from google.cloud import bigquery
from datetime import date, timedelta, datetime
from collections import namedtuple
Expand Down Expand Up @@ -197,27 +199,31 @@ def range_check(
if metric not in validation_data.columns.values:
raise Exception(f'dataframe does not include target metric "{metric}"')

print("Calculating dates for running range check...")
today = date.today()
latest_finished_at = max(validation_data["finished_at"])

test_earliest_date = today - timedelta(days=test_window)

comparison_earliest_date = test_earliest_date - timedelta(days=full_lookback_window)

print("Calculating comparison values...")
comparison_values = validation_data["finished_at"].apply(
lambda m: comparison_earliest_date < m.date() <= test_earliest_date
)
print("Calculating test values...")
test_values = validation_data["finished_at"].apply(
lambda m: test_earliest_date < m.date() <= today
)

print("Calculating comparison range and test range...")
comparison_range = validation_data.loc[comparison_values]
test_range = validation_data.loc[test_values]

print("Calculating upper and lower range limits...")
range_lower, range_upper = comparison_range[metric].quantile(
q=[range_lower_bound, range_upper_bound]
)

print("Recording whether the range check fails for the metric...")
should_trigger = len(test_range[metric]) != 0 and (
all(test_range[metric] > range_upper) or all(test_range[metric] < range_lower)
)
Expand Down
1 change: 1 addition & 0 deletions jobs/search-term-data-validation-v2/search_term_data_validation_v2/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
print("Hello from search_term_data_validation_v2/main.py!")
print("Look at me! I'm running a Python command! WOW!")

import argparse
Expand Down