Add breadcrumb when rate limiting fails to read the clock#7281
Add breadcrumb when rate limiting fails to read the clock#7281bendk wants to merge 1 commit intomozilla:mainfrom
Conversation
This rate limit check doesn't seem to be working in same cases, for example for https://bugzilla.mozilla.org/show_bug.cgi?id=2004954 I saw many reports per minute from the same user. I'm wondering if the cause is this check failing.
| // through seems okay in this case. We should get back into a good state soon | ||
| // after. | ||
| _ => (), | ||
| _ => { |
There was a problem hiding this comment.
I'm a little skeptical of this - I can see how extra single events might get through as the clock changes, but not how that could cause many reports per minute. What's your theory about how that actually happens in practice?
There was a problem hiding this comment.
It does seem really weird.
Here's what I'm looking at in grafana. One client is generating multiple error pings per second (I need to add a client filter, but for now I just added enough filters other that I'm pretty sure I'm only capturing one person).
I don't really understand what's going on. This is one wild theory, maybe there's something very wrong at the system level. My other theory was that the FF was restarting and clearing out the rate limiting data, but it seems impossible for FF to restart that much in practice. My only other theory was that it was part of some automation. This was really just a shot in the dark. Do you have any ideas on what could be happening?
(BTW, the unit in that graph is "errors / day" which is not right for unique clients. I think it's just one unique client, but since the interval is 2 hours it's multiplying to get 12 unique clients / day. I'm going to try to fix that today.)
This rate limit check doesn't seem to be working in same cases, for example for https://bugzilla.mozilla.org/show_bug.cgi?id=2004954 I saw many reports per minute from the same user. I'm wondering if the cause is this check failing.
Pull Request checklist
[ci full]to the PR title.