Bug 2020855 - add timestamps to breadcrumb data#7279
Conversation
ac36e37 to
beb7c2d
Compare
| tracing_support::info!(target: "app-services-error-reporter::breadcrumb", message, module, line, column); | ||
| } | ||
|
|
||
| fn add_breadcrumb_timestamp(message: &str, time: SystemTime) -> String { |
There was a problem hiding this comment.
I wonder if format might be a better prefix than add? I first expected to see this "add the breadcrumb" and was confused why the caller did the push. Not a bug deal though.
Also, is it at all possible we will want to order or group by timestamps? Should the timestamp maybe be appended instead, maybe inside parens?
There was a problem hiding this comment.
I updated the function name and put the timestamp at the end, both of those seem like solid improvements to me. I don't understand the group by timestamp part, how would that work?
Also removed the `tracing` dependency, which was optional and never used. All calls go through `tracing-support`.
beb7c2d to
6757240
Compare
Sorry I was unclear - I meant that the timestamp at the end would allow simpler grouping/sorting via the name |
Also removed the
tracingdependency, which was optional and never used. All calls go throughtracing-support.Pull Request checklist
[ci full]to the PR title.