test(ads-client): add OpenAPI schema contract tests against MARS spec#7276
Draft
Almaju wants to merge 1 commit intomozilla:mainfrom
Draft
test(ads-client): add OpenAPI schema contract tests against MARS spec#7276Almaju wants to merge 1 commit intomozilla:mainfrom
Almaju wants to merge 1 commit intomozilla:mainfrom
Conversation
5 tasks
db0aa52 to
844a4ea
Compare
Add openapi.json snapshot of the MARS spec and unit contract tests in ad_request.rs and ad_response.rs that validate our serialized types against the schema. Tests run on every cargo test invocation at zero network cost. Deviations from the spec are explicitly documented (click/impression callbacks are optional in spec but required by us; attributions field is not modelled and silently ignored).
844a4ea to
febc94a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openapi.jsonsnapshot of the MARS API specad_request.rsandad_response.rsthat validate our serialized types against the schema (runs on everycargo test, zero network cost)click/impressioncallbacks are optional in spec but required by us;attributionsfield is not modelled and silently ignoredPull Request checklist
[ci full]to the PR title.