test(ads-client): add integration tests against MARS staging with GitHub CI workflow#7275
Open
Almaju wants to merge 5 commits intomozilla:mainfrom
Open
test(ads-client): add integration tests against MARS staging with GitHub CI workflow#7275Almaju wants to merge 5 commits intomozilla:mainfrom
Almaju wants to merge 5 commits intomozilla:mainfrom
Conversation
5 tasks
d8d5a32 to
78066e5
Compare
78066e5 to
3be4824
Compare
Extracts the integration tests into a new `ads-client-integration-tests` crate under `components/ads-client/integration-tests/`. This keeps `viaduct-hyper` out of `ads-client`'s dev-dependencies entirely, since it was only needed to back the HTTP calls in those tests. - Remove `integration-tests` feature flag from `ads-client` - Remove `viaduct-hyper` from `ads-client` dev-dependencies - Add new crate to workspace `members` (not `default-members`) - Update CI workflow to run `cargo test -p ads-client-integration-tests`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[ignore]integration tests to useviaduct-hyperandMozAdsEnvironment::Stagingfor Image, Spoc, and Tile ad types.github/workflows/ads-client-tests.yaml) that runs these tests on every PR/push touchingcomponents/ads-client/**cargo test -p ads-client --test integration_test -- --ignoredPull Request checklist
Breaking changes: This PR follows our breaking change policy
[ci full]to the PR title.