Skip to content

test(ads-client): add integration tests against MARS staging with GitHub CI workflow#7275

Open
Almaju wants to merge 5 commits intomozilla:mainfrom
Almaju:ads-client-integration-tests
Open

test(ads-client): add integration tests against MARS staging with GitHub CI workflow#7275
Almaju wants to merge 5 commits intomozilla:mainfrom
Almaju:ads-client-integration-tests

Conversation

@Almaju
Copy link
Contributor

@Almaju Almaju commented Mar 18, 2026

Summary

  • Refactors existing #[ignore] integration tests to use viaduct-hyper and MozAdsEnvironment::Staging for Image, Spoc, and Tile ad types
  • Adds a GitHub Actions workflow (.github/workflows/ads-client-tests.yaml) that runs these tests on every PR/push touching components/ads-client/**
  • Run manually with: cargo test -p ads-client --test integration_test -- --ignored

Split from #7263

Pull Request checklist

Breaking changes: This PR follows our breaking change policy

  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@Almaju Almaju changed the title feat(ads-client): add integration tests against MARS staging with GitHub CI workflow test(ads-client): add integration tests against MARS staging with GitHub CI workflow Mar 18, 2026
@Almaju Almaju marked this pull request as draft March 18, 2026 21:14
@Almaju Almaju force-pushed the ads-client-integration-tests branch from d8d5a32 to 78066e5 Compare March 18, 2026 21:16
@Almaju Almaju force-pushed the ads-client-integration-tests branch from 78066e5 to 3be4824 Compare March 19, 2026 19:37
@Almaju Almaju marked this pull request as ready for review March 19, 2026 19:58
Almaju added 4 commits March 19, 2026 16:50
Extracts the integration tests into a new `ads-client-integration-tests`
crate under `components/ads-client/integration-tests/`. This keeps
`viaduct-hyper` out of `ads-client`'s dev-dependencies entirely, since
it was only needed to back the HTTP calls in those tests.

- Remove `integration-tests` feature flag from `ads-client`
- Remove `viaduct-hyper` from `ads-client` dev-dependencies
- Add new crate to workspace `members` (not `default-members`)
- Update CI workflow to run `cargo test -p ads-client-integration-tests`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant