fix: correct CutMix bounding box dimension swap#3932
Open
Mr-Neutr0n wants to merge 1 commit intomosaicml:mainfrom
Open
fix: correct CutMix bounding box dimension swap#3932Mr-Neutr0n wants to merge 1 commit intomosaicml:mainfrom
Mr-Neutr0n wants to merge 1 commit intomosaicml:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In CutMix, the bounding box computation swaps height and width dimensions — height is computed from the width extent and vice versa, leading to incorrectly shaped cutout regions.
The
_rand_bboxfunction declares parameters as(W, H)but callers pass(input.shape[2], input.shape[3])which is(H, W). This causescut_wto be computed from the height dimension andcut_hfrom the width dimension, and the clipping bounds to use the wrong spatial extent.Fix
Corrected the parameter order in
_rand_bboxfrom(W, H)to(H, W)so that it matches the call sites. Also fixed the corresponding keyword arguments in the test.