fix: Progressive Resizing logs height twice instead of width#3931
Open
Mr-Neutr0n wants to merge 2 commits intomosaicml:mainfrom
Open
fix: Progressive Resizing logs height twice instead of width#3931Mr-Neutr0n wants to merge 2 commits intomosaicml:mainfrom
Mr-Neutr0n wants to merge 2 commits intomosaicml:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Progressive Resizing logs the height value for both height and width, so the width is never correctly reported in logs.
In
resize_batch(), the debug log for new input dimensions usesX_sized.shape[2](height) twice instead ofX_sized.shape[2]for height andX_sized.shape[3]for width.Fix
Changed the second
X_sized.shape[2]toX_sized.shape[3]so the width dimension is correctly logged.