Add support for a --exclude option#18
Merged
mortenson merged 1 commit intomortenson:mainfrom Apr 14, 2025
Merged
Conversation
mortenson
reviewed
Apr 14, 2025
| } | ||
|
|
||
| // TestExcludeFlag tests that the exclude flag properly excludes tables from export | ||
| func TestExcludeFlag(t *testing.T) { |
Owner
There was a problem hiding this comment.
I think the existing runExportTestData implicitly does a lot of similar checks by comparing to the expectedRipoffFile, you could alternatively modify that function to check for the existence of an optional file like exclude.yml which contains an array of tables to exclude, then create a new dir in testdata/export that matches what you're doing now.
Comment on lines
+125
to
+135
| // stringSliceFlag is a custom flag to support multiple --exclude flags | ||
| type stringSliceFlag []string | ||
|
|
||
| func (s *stringSliceFlag) String() string { | ||
| return fmt.Sprintf("%v", *s) | ||
| } | ||
|
|
||
| func (s *stringSliceFlag) Set(value string) error { | ||
| *s = append(*s, value) | ||
| return nil | ||
| } |
Owner
There was a problem hiding this comment.
Cool, I've never done a custom flag.Value before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first Go PR ever so let me know if I doing something silly.
This should resolve #17