Add support for CSV escape character to EntityDataLoaderImpl#642
Open
puru-khedre wants to merge 2 commits intomoqui:masterfrom
Open
Add support for CSV escape character to EntityDataLoaderImpl#642puru-khedre wants to merge 2 commits intomoqui:masterfrom
puru-khedre wants to merge 2 commits intomoqui:masterfrom
Conversation
Member
|
I think the backwards compatibility of this change is fine, and this is worth merging as is |
Author
|
Hi @acetousk, Are we waiting for someone else's approval to merge this PR, or is there another issue? The method we are using for CSV parsing has been deprecated, so I am planning to fix it next. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #641
Add CSV escape character support to EntityDataLoaderImpl
csvEscapeCharproperty to define the escape character used in CSV parsing.This change allows for handling escape sequences in CSV files, dealing with special characters within quoted fields.