This repository was archived by the owner on Oct 1, 2024. It is now read-only.
glib: negate Marshaller compiler define#165
Open
knocte wants to merge 1 commit intomono:gtk-sharp-2-12-branchfrom
Open
glib: negate Marshaller compiler define#165knocte wants to merge 1 commit intomono:gtk-sharp-2-12-branchfrom
knocte wants to merge 1 commit intomono:gtk-sharp-2-12-branchfrom
Conversation
So that the define is only enabled with the old mono version, and no define is needed for modern versions.
Collaborator
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
Contributor
|
We need a separate method for this. Otherwise the JIT will crap out when trying to find the new Utf8 variant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the define is only enabled with the old mono
version, and no define is needed for modern versions.