Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors small pieces of the AST execution/safety-check logic in shell-bson-parser and makes minor cleanup tweaks in BSON-to-JS stringification in query-parser.
Changes:
- Flattened nested
ifchecks inexecuteAST/checkTreeinto a single compound condition. - Simplified
checkSafeCallcontrol flow by combiningallowMethods+ callee-type checks. - Minor cleanup in stringification: optional catch binding and using
new RegExp(...)for validation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/shell-bson-parser/src/eval.ts | Refactors executeAST condition structure. |
| packages/shell-bson-parser/src/check.ts | Refactors checkSafeCall and checkTree condition structure. |
| packages/query-parser/src/stringify.ts | Minor cleanup in date/regExp stringification error handling/validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean code
Checklist