Open
Conversation
This was referenced Jan 7, 2015
Member
|
This looks good, but there are several other events emitted by this method that need similarly updating. |
Author
|
I'm trying to leave the message ones until I figure out how I want to standard the message data, if that's what you mean? |
Member
|
Ok. Do you need input on that, or have you just not got to it yet? |
Author
|
I haven't gotten to it yet, but that doesn't make it mutually exclusive from wanting some input on it. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably needs a bit of thinking through/review since the entire message logic here is a little wonky.