Open
Conversation
39 tasks
malakada
changed the title
Member
There was a problem hiding this comment.
I think it's probably necessary to include the presence we received here as the state transition.
Author
There was a problem hiding this comment.
Ok. This is the one that I was most unsure of since it just simply passes along the entire stanza for other part of the code to pick through.
Member
There was a problem hiding this comment.
We should wrap that up into nicer accessors for the important bits for sure, but that can go lower priority.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trigger is used within Candy core here: https://github.com/mojolingo/candy/blob/dev/src/view.js#L69 which really calls this here: https://github.com/mojolingo/candy/blob/dev/src/view/observer.js#L150-L227
No where in that does it call
args.fromorargs.stanza. So uh, I'm not really sure how this is working unless the functionality was fixed/duplicated somewhere else?I'd like another set of eyes on this to make sure I'm not totally overlooking something.