Conversation
3d8b0a0 to
afc3e68
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 97.84% 97.77% -0.07%
==========================================
Files 17 17
Lines 1622 1666 +44
==========================================
+ Hits 1587 1629 +42
- Misses 35 37 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
741ed4c to
548bc2f
Compare
|
This PR cause problem for CFR video when trying to calculate the PTS over the video duration. For example, for mkv file, the duration can be setted with
With this sample, sample_8_frames.zip, we have those timestamps: Normally, the frame 8 would be 334, so in this case, we would need to round the result. So, in brief, since it add the PTS of the last frame (which is rounded) + the default duration, the result is basically junk. There isn't any way to solve this issue. |
548bc2f to
85e5190
Compare
8c47547 to
47e41b8
Compare
To test this, I generated a video with specific timestamps. The video is almost CFR except that the last frame duration is 25 ms instead of 50.
We don't need to duplicate the logic.
…ith VideoTimestamps and v2/v4 timestamps file
47e41b8 to
d12579e
Compare
This is needed for VFR video.
This depend on this PR: FFMS/ffms2#464
I'm waiting the ffms2 PR before merging this one.