Fix remaining cases where evaluable variability should be required#3861
Open
henrikt-ma wants to merge 9 commits intomodelica:masterfrom
Open
Fix remaining cases where evaluable variability should be required#3861henrikt-ma wants to merge 9 commits intomodelica:masterfrom
henrikt-ma wants to merge 9 commits intomodelica:masterfrom
Conversation
Besides some general cleanup, this fixes an issue with the wrong variability for the component condition.
This change is part of a sweep of addressing incorrect use of parameter variability. In this case, speaking of parameter variability in the example was technically not incorrect, but speaking of a particular expression variability seemed more confusing than helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3811. (The non-synchronous part of the issue has already been fixed by #3839.)