More detailed explanation of the two variants of using time.#3858
Open
HansOlsson wants to merge 1 commit intomodelica:masterfrom
Open
More detailed explanation of the two variants of using time.#3858HansOlsson wants to merge 1 commit intomodelica:masterfrom
HansOlsson wants to merge 1 commit intomodelica:masterfrom
Conversation
henrikt-ma
reviewed
Mar 30, 2026
| Additionally, it means that every sub-partition directly referencing \lstinline!time! contains a call to \lstinline!der!. | ||
| This means that \lstinline!time! can be used in two different ways. | ||
|
|
||
| The most intuitive is \lstinline!sample(time)! which works in any clocked partition, similarly as sampling any other continuous-time variable. |
Collaborator
There was a problem hiding this comment.
I get the impression that it should be emphasized that it can be part of a discrete-time sub-partition?
Suggested change
| The most intuitive is \lstinline!sample(time)! which works in any clocked partition, similarly as sampling any other continuous-time variable. | |
| The most intuitive is \lstinline!sample(time)!, which can be part of both discrete-time and discretized sub-partitions, similarly as sampling any other continuous-time variable. |
henrikt-ma
reviewed
Mar 30, 2026
| This means that \lstinline!time! can be used in different partitions without any restrictions. | ||
| Additionally, it means that every sub-partition directly referencing \lstinline!time! contains a call to \lstinline!der!. | ||
| This means that \lstinline!time! can be used in two different ways. | ||
|
|
Collaborator
There was a problem hiding this comment.
Instead of all these one or two sentence paragraphs, I think it will look better if we merge everything into a single non-normative paragraph on the theme of time.
Suggested change
henrikt-ma
reviewed
Mar 30, 2026
| This means that \lstinline!time! can be used in two different ways. | ||
|
|
||
| The most intuitive is \lstinline!sample(time)! which works in any clocked partition, similarly as sampling any other continuous-time variable. | ||
|
|
Collaborator
There was a problem hiding this comment.
As above:
Suggested change
henrikt-ma
reviewed
Mar 30, 2026
Comment on lines
+991
to
+992
| Additionally, \lstinline!time! can also be directly used in different clocked partitions without any restrictions. | ||
| However, every sub-partition directly referencing \lstinline!time! contains a call to \lstinline!der!, which makes it a discretized sub-partition \cref{discretized-partition}. |
Collaborator
There was a problem hiding this comment.
I didn't see the value of saying without any restrictions. Would this simplified one-sentence alternative work?
Suggested change
| Additionally, \lstinline!time! can also be directly used in different clocked partitions without any restrictions. | |
| However, every sub-partition directly referencing \lstinline!time! contains a call to \lstinline!der!, which makes it a discretized sub-partition \cref{discretized-partition}. | |
| On the other hand, if \lstinline!time! is used without sampling it in a clocked partition, it brings a use of \lstinline!der! to its sub-partition, and hence the sub-partition must be a discretized one (compare \cref{discretized-partition}). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3855