Merged
Conversation
Owner
|
Thanks for the contribution! You're right, doing so on these types right now introduces a subtle footgun, which is the deserialized data will not work correctly with Ghidra's Sleigh across executions. This is due to how libsla currently maps an address space for Ghidra by its address space id. So the footgun isn't due to this change, it's due to the subtle behavior of this mapping. I believe we can move to using the address space name to avoid issues with Sleigh in those cases. Documented in #11. Will fix that, then we can land this. |
mnemonikr
reviewed
Oct 16, 2025
soruh
force-pushed
the
add-serde-support
branch
from
4fb3d76 to
d533209
Compare
Contributor
Author
|
I rebased this onto the current main and added a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use the pcode instructions produced by this crate as an initial IR. As such I would like to persist intermediate steps to disk.
To make this possible, this PR adds the
serde-derivemacros to all exposed structs/enums if theserdefeature is enabled.This allows users to opt-into the serde dependency.
I have added some trivial tests.
I am not quite sure how the
AddressSpacees /AddressSpaceIds behave across different instances oflibslabut as far as I can see basically all structs/enums have only public fields anyways. So it was already possible to use possibly invalid address space ids before...For the tests I have added derives for
PartialEq, EqtoAssemblyInstructionandNativeDisassembly.