event handling, to extend to manage other hash arguments#36
Open
mikelmaron wants to merge 4 commits intomlevans:masterfrom
Open
event handling, to extend to manage other hash arguments#36mikelmaron wants to merge 4 commits intomlevans:masterfrom
mikelmaron wants to merge 4 commits intomlevans:masterfrom
Conversation
…viors (ie add/remove layers)
Contributor
|
Hi Mikel. I'm not exactly clear on the use case for this. Could you revise (fix formatting) and expand your description a bit? Also, can you use the same indentation and spacing style as the surrounding code, and include tests? |
Author
|
@jfirebaugh I've cleaned up the formatting, and added tests. The tests should hopefully illustrate the use case. Basically, this is used for keeping other elements of the map state in hash. So for instance, #13/51.5050/-0.0900&layers=HOT loads the humanitarian layer, similar to behavior on osm.org, but more integrated with leaflet-hash. |
Author
|
Could make sense to move the argument parsing functions in the test into leaflet itself, as convenience functions? |
useful for updating embed links and such
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event handling, to extend to manage other hash arguments and map behaviors.
our use case is representing state of visible tile layers in the hash.
adding/removing callback functions for when hash "change", or map "update". callback function manipulates hash, or takes action depending on hash.
after making a change to the map state, triggers a response to a map move
prevent updates while making a series of changes to the map, by bracketing the code block with these calls