Use "include" Leaflet API for addind methods to L.Map#14
Open
yohanboniface wants to merge 2 commits intomlevans:masterfrom
Open
Use "include" Leaflet API for addind methods to L.Map#14yohanboniface wants to merge 2 commits intomlevans:masterfrom
yohanboniface wants to merge 2 commits intomlevans:masterfrom
Conversation
Contributor
|
when you do it that way then you can't do var map = L.map('map').addHash();because it's not in the prototype chain yet, you can only do var map = L.map('map');
map.addHash(); |
Contributor
|
ignore the previous comment, for both ways you have to set view before you can add the hash |
Contributor
Author
|
We just need to add |
Contributor
|
no this turns out to be a different issue, you get an error if you do var map = L.map('map').addHash();instead of var map = L.map('map').setView([42.2, -71], 8).addHash();//or wherever |
Contributor
|
yeah my issue was actually part of #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to stay closer from Leaflet own usages.
Thanks!
Yohan