Modification and Clarification of Install#2
Open
mattaster wants to merge 2 commits intomlapeter:masterfrom
Open
Modification and Clarification of Install#2mattaster wants to merge 2 commits intomlapeter:masterfrom
mattaster wants to merge 2 commits intomlapeter:masterfrom
Conversation
added 2 commits
December 18, 2018 15:12
mlapeter
requested changes
Dec 18, 2018
Owner
mlapeter
left a comment
mlapeter
left a comment
There was a problem hiding this comment.
Should make it more clear, thanks! Can you change the git url's in package.json to point to the main repo, or should we just remove those alltogether?
Author
|
It might make sense to remove the package.json and add it to .gitignore.
Let me know your thoughts... technically npm init will override whatever we
put there anyways so it's a nice way to force them to run it.
…On Tue, Dec 18, 2018 at 5:11 PM Mike LaPeter ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Should make it more clear, thanks! Can you change the git url's in
package.json to point to the main repo, or should we just remove those
alltogether?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV66EM9jVeoMDdzCRB6G1vwhiGSabkFkks5u6WgJgaJpZM4ZZBGk>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see changes.