Skip to content

fix: improve runway parsing #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f-loris wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve runway parsing #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion metarParser-parsers/src/main/java/io/github/mivek/command/metar/RunwayCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,13 @@ private String parseDepositThickness(final String input) {
* @return Translated sentence representing the braking capacity.
*/
private String parseDepositBrakingCapacity(final String input) {
if ("//".equals(input)) {
return messages.getString(DEPOSIT_BRAKING_CAPACITY_MAP.get(input));
}
return messages.getString(DEPOSIT_BRAKING_CAPACITY_MAP.getOrDefault(input, "DepositBrakingCapacity.default"), Double.parseDouble(input) / 100);
}
@Override
public boolean canParse(final String input) {
return Regex.find(GENERIC_RUNWAY_REGEX, input);
}
}

23 changes: 20 additions & 3 deletions metarParser-parsers/src/test/java/io/github/mivek/command/metar/RunwayCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,26 @@ void testParseRunwayWithGreaterThanIndicator() throws ParseException {
}

@Test
void testParseRunwayWithIncompleteInfo() {
void testParseRunwayWithNoInfo() throws ParseException {
Metar m = new Metar();
ParseException e = assertThrows(ParseException.class, () -> command.execute(m, "R16///////"));
assertEquals(Messages.getInstance().getString("ErrorCode.IncompleteRunwayInformation"), e.getErrorCode().getMessage());

command.execute(m, "R16///////");
assertThat(m.getRunways(), hasSize(1));
RunwayInfo ri = m.getRunways().get(0);
assertEquals("16", ri.getName());
assertEquals(DepositType.NOT_REPORTED, ri.getDepositType());
assertEquals(DepositCoverage.NOT_REPORTED, ri.getCoverage());
}

@Test
void testParseRunwayWithPartialInfo() throws ParseException {
Metar m = new Metar();

command.execute(m, "R88/29////");
assertThat(m.getRunways(), hasSize(1));
RunwayInfo ri = m.getRunways().get(0);
assertEquals("88", ri.getName());
assertEquals(DepositType.WET_WATER_PATCHES, ri.getDepositType());
assertEquals(DepositCoverage.FROM_51_TO_100, ri.getCoverage());
}
}
Loading