Conversation
|
Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue. |
OSSRH is now deprecated. This migrates to maven central repository.
Automatic analysis in now activated on the project.
mivek
force-pushed
the
build/maven-central
branch
from
53aad13 to
de5415e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from the deprecated OSSRH staging to the Maven Central publishing plugin and updates related configurations.
- Replace the Maven Nexus staging plugin and OSSRH IDs with the central-publishing-maven-plugin and “central” IDs
- Add
<name>elements to all submodule POMs for clearer module identification - Update
.settings.xmland GitHub Actions workflows to use new Maven Central credentials and remove legacy Sonar workflows
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Update distributionManagement IDs and swap nexus-staging-maven-plugin for central-publishing-maven-plugin |
| metarParser-spi/pom.xml | Add <name> element |
| metarParser-services/pom.xml | Add <name> element |
| metarParser-parsers/pom.xml | Add <name> element |
| metarParser-entities/pom.xml | Add <name> element |
| metarParser-commons/pom.xml | Add <name> element |
| .settings.xml | Change server ID/env vars for central, remove old OSSRH profile |
| .github/workflows/sonar-master.yml | Remove legacy SonarCloud CI workflow |
| .github/workflows/release.yml | Update Maven Central server ID and credential environment variables |
| .github/workflows/build_sonar_verify.yml | Remove legacy Sonar verify workflow |
Comments suppressed due to low confidence (4)
pom.xml:341
- Consider specifying an explicit in the central-publishing-maven-plugin configuration to ensure it always targets the correct Sonatype endpoint, even if the plugin's defaults change in a future version.
<groupId>org.sonatype.central</groupId>
.settings.xml:6
- The old OSSRH profile was removed—ensure that any local or CI builds relying on that profile are updated or documented, so the new default server credentials are applied consistently.
<id>central</id>
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSSRH is now deprecated. This migrates to maven central repository.