feat: parse TAF messages without delivery time#701
Merged
Conversation
When a TAF message does not contain a delivery time, the validity time is taken as delivery time.
|
Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TAF parser to handle messages that omit an explicit delivery time by using the validity start as the delivery time.
parseDeliveryTimenow returns a boolean indicating if the token was a delivery time, so the parser can skip tokens appropriately.TAFParseruses the return value to decide whether to advance to the validity time token or reuse it.- A new unit test (
testParseWithoutDeliveryTime) verifies the no-delivery-time scenario.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| metarParser-parsers/src/main/java/io/github/mivek/parser/TAFParser.java | Adjusted index increment logic around delivery/validity tokens |
| metarParser-parsers/src/main/java/io/github/mivek/parser/AbstractWeatherCodeParser.java | Changed parseDeliveryTime to return boolean and updated its logic |
| metarParser-parsers/src/test/java/io/github/mivek/parser/TAFParserTest.java | Added a test for parsing a TAF message without an explicit delivery time |
Comments suppressed due to low confidence (2)
metarParser-parsers/src/main/java/io/github/mivek/parser/AbstractWeatherCodeParser.java:51
- [nitpick] The method name
parseDeliveryTimedoesn’t convey its boolean return semantics. Consider renaming to something liketryParseDeliveryTimeorconsumeDeliveryTimeIfPresentfor clarity.
boolean parseDeliveryTime(final AbstractWeatherCode weatherCode, final String time) {
metarParser-parsers/src/test/java/io/github/mivek/parser/TAFParserTest.java:960
- It would be helpful to add a complementary test case where the TAF message includes an explicit delivery time (with minutes) to ensure the original behavior remains correct.
void testParseWithoutDeliveryTime() throws ParseException {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TAF message does not contain a delivery time, the validity time is taken as delivery time.
Back-port of mivek/python-metar-taf-parser#73