refactor: rework the MinimalVisibilityCommand regex#700
Merged
Conversation
|
Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue. |
There was a problem hiding this comment.
Pull Request Overview
Refactors the MinimalVisibilityCommand to use a more precise regex that captures numeric visibility and direction separately, normalizes input to uppercase before matching, and updates tests to align with these changes.
- Clarified regex to explicitly capture the four-digit visibility and one- or two-letter compass directions
- Uppercases input in
executeandcanParseand adjusts group indexing - Updated existing test and added parameterized tests for all uppercase directions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| metarParser-parsers/src/test/java/io/github/mivek/parser/MetarParserTest.java | Changed expected minimal visibility direction from lowercase to uppercase |
| metarParser-parsers/src/test/java/io/github/mivek/command/common/MinimalVisibilityCommandTest.java | Added parameterized tests for each uppercase compass direction |
| metarParser-parsers/src/main/java/io/github/mivek/command/common/MinimalVisibilityCommand.java | Refactored regex, applied toUpperCase() on input, and split groups for digits and direction |
Comments suppressed due to low confidence (1)
metarParser-parsers/src/test/java/io/github/mivek/command/common/MinimalVisibilityCommandTest.java:13
- Consider adding tests for lowercase direction inputs (e.g., "nw") to ensure the command correctly handles case-insensitive input after uppercasing.
@ValueSource(strings = {"NW", "N","NE","E","SE","S","SW","W"})
metarParser-parsers/src/main/java/io/github/mivek/command/common/MinimalVisibilityCommand.java
Show resolved
Hide resolved
metarParser-parsers/src/main/java/io/github/mivek/command/common/MinimalVisibilityCommand.java
Show resolved
Hide resolved
f7ea459 to
558efa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.