feat: improve performance in AirportSupplier by resolving the provide…#688
Merged
feat: improve performance in AirportSupplier by resolving the provide…#688
Conversation
|
Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue. |
mivek
force-pushed
the
feat/airportsupplier-optimization
branch
from
760964c to
76b3ae4
Compare
…r once in the constructor
mivek
force-pushed
the
feat/airportsupplier-optimization
branch
from
76b3ae4 to
97374b4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance in the AirportSupplier class by resolving the airport provider once during construction instead of on every call.
- Caches the airport provider in the constructor.
- Removes repetitive ServiceLoader lookups in the get method.
metarParser-parsers/src/main/java/io/github/mivek/command/AirportSupplier.java
Show resolved
Hide resolved
|
🎉 This PR is included in version 2.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Owner
Author
|
This fixes #687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r once in the constructor.