allow (s)css and image files as entry points#6
allow (s)css and image files as entry points#6mindplay-dk merged 8 commits intomindplay-dk:masterfrom
Conversation
mindplay-dk
left a comment
There was a problem hiding this comment.
I'm a bit concerned about the number of fallthrough cases in createPreloadTags - I can sort of vaguely grasp at why this actually works and makes sense, but it's been a year+ since I wrote this, and it's honestly all pretty hazy at this point. Which is more a comment on my own code than it is on your contribution! 😅
You seem to have a solid profile and reputation, and you probably know more about it in this moment than I did when I wrote it. 🤷♂️😊
So I guess let's get this merged as soon as the little things I mentioned are resolved.
If you'd like, you can add your information to the package.json as well.
And I guess, since this project appears to matter more to you right now than it does to me, I'd also be open to making you a contributor here on Github, if you'd like? 🙂
|
Good call 😄 Do you know what the code coverage level was before you started? Unfortunately Github deletes the logs. It's 94% now. If it was 100% before, I'd like to bring it back to 100% before release, just to be on the safe side. If it wasn't, then it's probably fine - I don't strive for 100% as a rule or anything. 😊 |
no
I dont have a coverage driver installed on my system, so I can't see what's missing. |
|
Released as version |
Our company uses a Laminas-based PHP application. We use plain native JS and Bootstrap with Sass. So we need (S)CSS files as Entry points. We also want to use Vite for Image optimisation and need Image Entry points too.
This PR is inspired by PR #4.