NpmDsc: Avoid Set false positives with owner/repo packages#249
NpmDsc: Avoid Set false positives with owner/repo packages#249guillermooo wants to merge 1 commit intomicrosoft:mainfrom
Set false positives with owner/repo packages#249Conversation
The old implementation didn't account for all possible `one/two` package names accepted by `npm install`. We now limit user input to package names that won't yield false positives in these cases. NOTES: The fix is actually restricted to `one/two` type of names; other legal values for a package name may still yield false positives if they reference a code repository. (Untested)
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)npmjs These words are not needed and should be removedJan PSobject tokio wingetTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:guillermooo/winget-dsc.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/22830435532/attempts/1'
Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See If the flagged items are 🤯 false positivesIf items relate to a ...
|
The old implementation didn't account for all possible
one/twopackage names accepted bynpm install.We now limit user input to package names that won't yield false positives in these cases.
NOTES:
The fix is actually restricted to
one/twotype of names; other legal values for a package name may still yield false positives if they reference a code repository. (Untested)Microsoft Reviewers: Open in CodeFlow