fix: update nightly macro expansion test outputs#509
Merged
wmmc88 merged 1 commit intomicrosoft:mainfrom Sep 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request reverts macro expansion test output changes to match a nightly rustc change that was reverted upstream. The changes simplify assertion logic for validating WDF function table size calculations.
- Replaces verbose
matchstatement assertions with conciseif !...conditional checks - Updates macro-generated test output files to reflect the reverted rustc behavior
- Maintains the same assertion functionality with improved readability
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wdf_verifier_dbg_break_point.expanded.rs | Updates assertion pattern from match to if conditional |
| wdf_spin_lock_acquire.expanded.rs | Updates assertion pattern from match to if conditional |
| wdf_request_retrieve_output_buffer.expanded.rs | Updates assertion pattern from match to if conditional |
| wdf_driver_create.expanded.rs | Updates assertion pattern from match to if conditional |
| wdf_device_create_device_interface.expanded.rs | Updates assertion pattern from match to if conditional |
| wdf_device_create.expanded.rs | Updates assertion pattern from match to if conditional |
| bug_unused_imports.expanded.rs | Updates assertion pattern from match to if conditional |
| bug_tuple_struct_shadowing.expanded.rs | Updates assertion pattern from match to if conditional |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
leon-xd
approved these changes
Sep 12, 2025
hamzamust
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way assertions are performed when validating the size of the WDF function table in several macro-generated test files. The previous pattern using a
matchstatement has been replaced with a more conciseif !...conditional, simplifying the code and improving readability.This essentially reverts the expansion changes made in #501 because of the nightly rustc change that was reverted in rust-lang/rust#146428
Assertion logic refactor:
matchstatement with a directif !isize::try_from(...).is_ok()check for validating the conversion of the WDF function count and size toisize, followed by a panic if the assertion fails, across all affected test output files. [1] [2] [3] [4] [5] [6] [7] [8]