feat: add slog/logr logging bridges and update shared utilities#2041
Open
nddq wants to merge 1 commit intomicrosoft:cilium/v1.19-upgradefrom
Open
feat: add slog/logr logging bridges and update shared utilities#2041nddq wants to merge 1 commit intomicrosoft:cilium/v1.19-upgradefrom
nddq wants to merge 1 commit intomicrosoft:cilium/v1.19-upgradefrom
Conversation
nddq
requested review from
ibezrukavyi and
mugeshsp
and removed request for
a team
nddq
force-pushed
the
cilium/v1.19-pr3-utilities
branch
from
7f23b3a to
c6436b9
Compare
nddq
force-pushed
the
cilium/v1.19-pr3-utilities
branch
2 times, most recently
from
3533329 to
f760df8
Compare
- Add slog/logr bridge in pkg/log/zap.go for Cilium v1.19 - Update pkg/utils/flow_utils.go with structpb extensions - Migrate metrics package to slog-compatible interface - Remove unused ITracer mock - Update pkg/config, pkg/common/endpoint.go, and Hubble decoder Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
nddq
force-pushed
the
cilium/v1.19-pr3-utilities
branch
from
f760df8 to
cd2f7ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pkg/log/zap.gofor Cilium v1.19 slog-based loggingpkg/utils/flow_utils.gowith structpb extensions and fix protogetter/gofmt lint issuesITracermock (pkg/plugin/common/mocks/mock_types.go)pkg/config,pkg/common/endpoint.go, and Hubble decoder for v1.19 compatibilityPR 3 of 7 for Cilium v1.19 upgrade.
Related Issue
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
pkg/logtests pass with new slog bridgepkg/metricstests pass with updated interfaceflow_utils.go(protogetter, gofmt)Additional Notes
None.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.