Skip to content

Add runtime warning for unsupported keyboardType #15778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Nitin-100 wants to merge 2 commits into
base: 0.82-stable
Choose a base branch
from
Draft

Add runtime warning for unsupported keyboardType #15778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7884c98
feat(TextInput): Add runtime warning for unsupported keyboardType pro…
Mar 16, 2026
57ee42b
Change files
Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-21c97e41-4926-4bce-98ce-832b24378038.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add runtime warning for unsupported keyboardType prop on Fabric TextInput",
"packageName": "react-native-windows",
"email": "nitchaudhary@microsoft.com",
"dependentChangeType": "patch"
}
26 changes: 26 additions & 0 deletions vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "guid/msoGuid.h"

#include <unicode.h>
#include <unordered_set>

// convert a BSTR to a std::string.
std::string &BstrToStdString(const BSTR bstr, std::string &dst, int cp = CP_UTF8) {
Expand Down Expand Up @@ -61,6 +62,19 @@ MSO_CLASS_GUID(ITextServices2, "8D33F741-CF58-11CE-A89D-00AA006CADC5") // IID_IT

namespace winrt::Microsoft::ReactNative::Composition::implementation {

namespace {
// Track which prop warnings have been emitted to avoid spamming the developer
static std::unordered_set<std::string> s_emittedPropWarnings;

// Emit a warning once per unique message
void EmitPropWarningOnce(const std::string &warningKey, const std::string &message) {
if (s_emittedPropWarnings.find(warningKey) == s_emittedPropWarnings.end()) {
s_emittedPropWarnings.insert(warningKey);
OutputDebugStringA(("[React Native Windows] " + message + "\n").c_str());
}
}
} // namespace

// RichEdit doesn't handle us calling Draw during the middle of a TxTranslateMessage call.
WindowsTextInputComponentView::DrawBlock::DrawBlock(WindowsTextInputComponentView &view) : m_view(view) {
m_view.m_cDrawBlock++;
Expand Down Expand Up @@ -1198,6 +1212,18 @@ void WindowsTextInputComponentView::updateProps(
m_needsRedraw = true;
}

// Warn about props that are not yet implemented on Windows
if (!newTextInputProps.keyboardType.empty() && newTextInputProps.keyboardType != "default") {
EmitPropWarningOnce(
"TextInput.keyboardType",
"The keyboardType prop for TextInput is not yet available on React Native Windows Fabric. "
"See: https://microsoft.github.io/react-native-windows/docs/new-arch-missingProps . "
"Setting keyboardType=\"" +
newTextInputProps.keyboardType +
"\" will not change the Touch Keyboard layout. "
"Currently supported value: 'default'");
}

UpdatePropertyBits();
}

Expand Down
Loading