Improve Trampoline ergonomics#48
Merged
sivadeilra merged 7 commits intomicrosoft:mainfrom Feb 27, 2026
Merged
Conversation
ranweiler
commented
Feb 25, 2026
| zerocopy-derive.workspace = true | ||
|
|
||
| [dev-dependencies] | ||
| hex-literal.workspace = true |
Contributor
Author
There was a problem hiding this comment.
Happy to tear this out and write out a raw slice if you prefer. That said, I've found the macro this crate exports to be very handy for unit testing.
ranweiler
force-pushed
the
joranwei/trampoline-fields
branch
from
13fedf5 to
b087dc6
Compare
sivadeilra
reviewed
Feb 27, 2026
sivadeilra
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR offers two changes:
TrampolineFixedfor readability and consistency with other symbol structsTrampolineFixedmethods to view its logical[segment:offset]pairs asOffsetSegmentvaluesThe renamed fields constitute a breaking change.
I originally planned on changing the parsing logic of
TrampolineFixedto allow direct embeddingOffsetSegmentvalues in the struct. But, upon inspection, parsing is nicely trivial if we preserve the actual serialized order of the fields. To retain this simplicity, while also getting the QOL and uniformity of havingOffsetSegmentvalues, I just added accessors for users who might want them. By preserving serialized field order in theTrampolineFixeddefinition, we also retain conventional consistency with other..Fixedstructs.