Open
Conversation
When cross-compiling for ARM64 on an x64 host, CMAKE_SYSTEM_PROCESSOR (AMD64) was matching the x64 condition before reaching ARM64, causing the wrong redirect lib to be linked. Add 'AND NOT CMAKE_GENERATOR_PLATFORM STREQUAL ARM64' to the x64 detection to let ARM64 builds fall through to the correct condition. Cherry-picked from dev branch (PR #1244).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cross-compiling for ARM64 on an x64 host, CMAKE_SYSTEM_PROCESSOR (AMD64) matches the x64 condition before reaching ARM64, causing MI_ARCH to be set to x64 instead of arm64. This results in the wrong redirect lib being linked.
Fix: Add AND NOT CMAKE_GENERATOR_PLATFORM STREQUAL ARM64 to the x64 detection so ARM64 builds correctly fall through to the arm64 condition.
Cherry-picked from the dev branch (PR #1244).