Add 'Azure Well-Architected Framework' tool#1964
Open
sriramkakara wants to merge 6 commits intomainfrom
Open
Conversation
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Azure Well-Architected Framework MCP tool/area to the Azure MCP Server, enabling clients/skills to retrieve service-specific WAF guidance via a dedicated command and embedded service-guide mappings.
Changes:
- Introduces
Azure.Mcp.Tools.WellArchitectedFrameworkwithserviceguide getcommand backed by an embeddedservice-guides.jsonmapping. - Wires the new area into Azure MCP Server registration and updates command docs, prompts, README, and consolidated tool mappings.
- Adds unit tests validating both the embedded JSON schema and the command behavior.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.WellArchitectedFramework/tests/Azure.Mcp.Tools.WellArchitectedFramework.UnitTests/ServiceGuidesJsonSchemaTests.cs | Adds schema/content validation for the embedded service-guides.json. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/tests/Azure.Mcp.Tools.WellArchitectedFramework.UnitTests/ServiceGuideGetCommandTests.cs | Adds unit tests for serviceguide get behavior and option binding. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/tests/Azure.Mcp.Tools.WellArchitectedFramework.UnitTests/Azure.Mcp.Tools.WellArchitectedFramework.UnitTests.csproj | Adds the unit test project for the new tool. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/WellArchitectedFrameworkSetup.cs | Registers the new area and serviceguide get command group. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Resources/ServiceGuides/service-guides.json | Adds the service-to-guide URL mapping and variations list used for lookups. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Resources/ServiceGuides/service-guides-generation-prompt.md | Adds a prompt to regenerate the JSON mapping from WAF TOC. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Options/WellArchitectedFrameworkOptionDefinitions.cs | Defines --service option for the new command. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Options/ServiceGuide/ServiceGuideGetOptions.cs | Adds options model for the serviceguide get command. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/GlobalUsings.cs | Introduces global using for System.CommandLine. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/WellArchitectedFrameworkJsonContext.cs | Adds STJ source-gen context for command responses. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs | Implements the serviceguide get command and embedded JSON loading + lookup logic. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/Azure.Mcp.Tools.WellArchitectedFramework.csproj | Adds the new tool project and embeds JSON/text resources. |
| tools/Azure.Mcp.Tools.WellArchitectedFramework/src/AssemblyInfo.cs | Exposes internals to unit/live test assemblies. |
| servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json | Adds the new tool into the consolidated “get_azure_best_practices” grouping/description. |
| servers/Azure.Mcp.Server/src/Program.cs | Registers the new Well-Architected Framework area setup. |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Adds E2E prompts for the new tool. |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Documents the new azmcp wellarchitectedframework serviceguide get command. |
| servers/Azure.Mcp.Server/README.md | Adds user-facing examples and updates supported area count/list. |
| .github/CODEOWNERS | Adds codeowners + PR label metadata for the new tool path. |
...Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs
Outdated
Show resolved
Hide resolved
...Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs
Show resolved
Hide resolved
...Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs
Outdated
Show resolved
Hide resolved
....Mcp.Tools.WellArchitectedFramework/src/Options/WellArchitectedFrameworkOptionDefinitions.cs
Outdated
Show resolved
Hide resolved
...Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs
Outdated
Show resolved
Hide resolved
alzimmermsft
reviewed
Mar 9, 2026
...Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs
Outdated
Show resolved
Hide resolved
...Azure.Mcp.Tools.WellArchitectedFramework/src/Commands/ServiceGuide/ServiceGuideGetCommand.cs
Show resolved
Hide resolved
...ols.WellArchitectedFramework/src/Resources/ServiceGuides/service-guides-generation-prompt.md
Show resolved
Hide resolved
KarishmaGhiya
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
Azure.Mcp.Tools.WellArchitectedFrameworktoolThis tool provides quick and efficient access to any skill that needs to refer to the 'Azure Well-Architected Framework' for architecture guidelines.
Ex: We have an Azure infrastructure planning skill which needs to refer to WAF to come up with the best possible architecture.
GitHub issue number?
Issue 1927
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline