Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the pai_build.py build/push tooling to support authenticating to container registries via Azure Managed Identity (MI) in addition to username/password, and changes the flow so registry login happens only when pushing images (not during image build).
Changes:
- Add
managed-identity-idsupport in config parsing and CLI flags. - Update
DockerClientto support MI-based Azure CLI + ACR login when username/password aren’t provided. - Move docker registry login to
push_center()sobuildno longer triggers login.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build/pai_build.py | Adds CLI flags for MI and updates config override logic. |
| build/model/config_model.py | Parses managed-identity-id from build configuration YAML into dockerRegistryInfo. |
| build/core/build_utility.py | Extends DockerClient to support MI/Azure CLI login and removes automatic login during initialization. |
| build/core/build_center.py | Passes managedIdentityId into DockerClient and performs login only before pushing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following features: