Pass Device Addr (IP:Port) to JRTC Apps#84
Merged
doctorlai-msrc merged 6 commits intomainfrom Jul 15, 2025
Merged
Conversation
bradunov
reviewed
Jul 15, 2025
Collaborator
bradunov
left a comment
There was a problem hiding this comment.
Please address my comments
bradunov
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes the ip:port/device-id from deployment yaml to the jrtc app env context. This PR also adds assertions in test_apps/first_example_py to make sure these values are passed correctly.
This PR refactors the function
_is_app_loaded()When app_type is "python", the python script is stored in parameters, thus this is used to check if the app has been loaded. For normal C/C++ app, the app is checked via the .so which is stored in app_path.