Fix es5/bundled and typescript benchmark files#285
Merged
ZihanChen-MSFT merged 1 commit intomicrosoft:mainfrom Mar 19, 2026
Merged
Fix es5/bundled and typescript benchmark files#285ZihanChen-MSFT merged 1 commit intomicrosoft:mainfrom
ZihanChen-MSFT merged 1 commit intomicrosoft:mainfrom
Conversation
vmoroz
approved these changes
Mar 19, 2026
ZihanChen-MSFT
force-pushed
the
running-benchmark-ts-react
branch
from
532f938 to
c90c476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow a bit more benchmark to work.
raytracer.tsis about typescript files loading. Hermes seems not being able to understand new typescript syntax, I didn't figure out why it (with such syntax) wassubmitted from the beginning. But by a little bit twisted, it works. More importantly, types are preserved, which means if types are considered by hermes, the benchmark still work with them.If in the future hermes got improve, probably from the upstream, these branchmark changes can be reverted and verified by bench.ts.
Along with tiny fixing in bench.ts
Test Plan
Manually tested. A new benchmark sample uploaded as a result.
Microsoft Reviewers: Open in CodeFlow