[shimV2] added network controller implementation#2633
Open
rawahars wants to merge 2 commits intomicrosoft:mainfrom
Open
[shimV2] added network controller implementation#2633rawahars wants to merge 2 commits intomicrosoft:mainfrom
rawahars wants to merge 2 commits intomicrosoft:mainfrom
Conversation
jterry75
requested changes
Mar 17, 2026
This change adds the network controller implementation for V2 shims which manages the network lifecycle for a single pod running inside a UVM. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
network-controller
branch
from
0336432 to
e901ab7
Compare
jterry75
reviewed
Mar 20, 2026
| vmNetManager vmmanager.NetworkManager, | ||
| linuxGuestMgr guestmanager.LCOWNetworkManager, | ||
| windowsGuestMgr guestmanager.WCOWNetworkManager, | ||
| vmNetManager vmNetworkManager, |
Contributor
There was a problem hiding this comment.
How can the caller call this with an unexported interface type? I didn't know that was possible?
Contributor
Author
There was a problem hiding this comment.
Yes, this relies on Go's implicit interfaces. As long as the provided argument implements the required method set, Go verifies the structural match at compile time.
jterry75
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the network controller implementation for V2 shims which manages the network lifecycle for a single pod running inside a UVM. The implementation provides a clear lifecycle state machine, separates platform-specific logic for LCOW and WCOW. This controller will be initialized from VMController which can inject the low-level managers to perform VM host + guest network operations.
The main changes are grouped below.
Network controller implementation:
Controllerinterface and its concreteManagertype, providingSetupandTeardownmethods to manage HCN namespaces and endpoints for a pod (internal/controller/network/interface.go,internal/controller/network/network.go).Platform-specific guest operations:
internal/controller/network/network_lcow.go,internal/controller/network/network_wcow.go).Lifecycle state management:
Statetype to track the network lifecycle, including transitions for setup, teardown, and error handling (internal/controller/network/state.go).