Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies selection behavior for the nocgo OpenSSL backend and documents runtime library dependencies when using the cgo-less implementation.
Changes:
- Rewrites the backend-selection section into explicit decision bullets (CGO_ENABLED=1/0/default behavior).
- Adds a “Runtime dependencies” section describing required glibc libs and notes about glibc 2.34+.
You can also share your feedback on Copilot code review. Take the survey.
gdams
approved these changes
Mar 19, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
gdams
approved these changes
Mar 19, 2026
dagood
reviewed
Mar 19, 2026
dagood
reviewed
Mar 19, 2026
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
dagood
approved these changes
Mar 20, 2026
Member
|
/azp run microsoft-go (IIRC this will get it to use a newer merge commit to skip #2200...) |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No pipelines are associated with this pull request. |
Member
Didn't work, but some more of the macOS failures passed. Maybe it's over? Hitting retry again. Closing and re-opening would probably have worked, but that would redo the GitHub Actions workflows too I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify how the nocgo mode is selected and add a runtime dependencies section.