Skip to content

Dev: fix issues#246

Merged
Chenglong-MS merged 4 commits intomainfrom
dev
Mar 4, 2026
Merged

Dev: fix issues#246
Chenglong-MS merged 4 commits intomainfrom
dev

Conversation

@Chenglong-MS
Copy link
Collaborator

This pull request introduces several layout and dependency updates to improve the application's responsiveness and maintainability. The most significant changes focus on fixing scroll and overflow issues in the main app container, updating the layout of the DataFormulator view, and adding a new dependency.

Layout and Overflow Improvements:

  • Updated the main app container in App.tsx to use overflow: 'auto' and reduced the minimum height of child elements, which helps resolve scroll issues and improves the application's responsiveness.
  • Refactored the router area in App.tsx by wrapping it in a Box with flex: 1, minHeight: 0, and overflow: 'hidden', ensuring the router content properly fills available space and avoids unwanted overflow.

CSS and Root Element Adjustments:

  • Modified index.css to set body to overflow: hidden and moved scroll handling to #root with overflow: auto, providing better control over scrolling and fixing layout bugs.

DataFormulator Layout Fixes:

  • Adjusted the margin and height calculations for the main container in DataFormulator.tsx to improve spacing and ensure consistent layout, especially after drag-and-drop operations.
  • Changed the outer container height in DataFormulator.tsx to use height: '100%' instead of calc(100% - 54px), ensuring the view fills the available space more reliably.

Dependency Update:

  • Added js-yaml as a new dependency in package.json, enabling YAML parsing capabilities for future features or data handling.

@Chenglong-MS Chenglong-MS requested a review from Mestway March 4, 2026 00:52
Copy link
Collaborator

@Mestway Mestway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Chenglong-MS Chenglong-MS merged commit 676e722 into main Mar 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants