Merged
Conversation
ci: refactor notification email templates
ci: update notification subjects to include status icons
chore: Dev to Main merge
Avijit-Microsoft
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment workflow to improve resource cleanup handling and notification reporting. The main changes include moving the
cleanup-deploymentjob earlier in the workflow, ensuring its result is passed to the notification step, and updating input requirements for notification jobs. These changes make the workflow more robust and flexible, especially in handling optional steps and reporting their outcomes.Workflow orchestration improvements:
cleanup-deploymentjob is now run before sending notifications, and its outputs are passed as inputs to the notification job. This ensures that cleanup results are available for reporting and that notifications reflect the full job sequence. (.github/workflows/deploy-orchestrator.yml) [1] [2]Notification job enhancements:
e2e_test_resultinput injob-send-notification.ymlis now optional with a default value, allowing for cases where E2E tests may be skipped. (.github/workflows/job-send-notification.yml)cleanup_result, is added tojob-send-notification.ymlto capture and report the result of the cleanup job, defaulting to'skipped'. (.github/workflows/job-send-notification.yml)Does this introduce a breaking change?
Golden Path Validation
Deployment Validation