Skip to content

chore: main to dev down merge#805

Merged
Avijit-Microsoft merged 9 commits intodevfrom
main
Apr 9, 2026
Merged

chore: main to dev down merge#805
Avijit-Microsoft merged 9 commits intodevfrom
main

Conversation

@Ragini-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request updates the deployment workflow to improve resource cleanup handling and notification reporting. The main changes include moving the cleanup-deployment job earlier in the workflow, ensuring its result is passed to the notification step, and updating input requirements for notification jobs. These changes make the workflow more robust and flexible, especially in handling optional steps and reporting their outcomes.

Workflow orchestration improvements:

  • The cleanup-deployment job is now run before sending notifications, and its outputs are passed as inputs to the notification job. This ensures that cleanup results are available for reporting and that notifications reflect the full job sequence. (.github/workflows/deploy-orchestrator.yml) [1] [2]

Notification job enhancements:

  • The e2e_test_result input in job-send-notification.yml is now optional with a default value, allowing for cases where E2E tests may be skipped. (.github/workflows/job-send-notification.yml)
  • A new optional input, cleanup_result, is added to job-send-notification.yml to capture and report the result of the cleanup job, defaulting to 'skipped'. (.github/workflows/job-send-notification.yml)

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants