fix: read turn_id instead of turn from Copilot SDK events#85
Open
taipoweredpm wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: read turn_id instead of turn from Copilot SDK events#85taipoweredpm wants to merge 1 commit intomicrosoft:mainfrom
taipoweredpm wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The Copilot SDK exposes the turn number as 'turn_id' on event.data, not 'turn'. The incorrect attribute name caused getattr to always return None, resulting in 'Turn ?' in the web dashboard and missing turn info in console output. Fixes microsoft#62 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the web dashboard showing Turn ? instead of the actual turn number when using the Copilot provider.
Root Cause
The Copilot SDK exposes the turn number as urn_id on �vent.data, not urn. The two getattr(event.data, "turn", ...) calls in CopilotProvider always returned None, causing the dashboard's nullish fallback to render "Turn ?".
Changes
Two-line fix in src/conductor/providers/copilot.py:
The callback payload key remains "turn" — only the SDK attribute name changes.
Fixes #62