Disable Kusto emulator tests on Linux#15464
Open
sebastienros wants to merge 3 commits intomicrosoft:mainfrom
Open
Disable Kusto emulator tests on Linux#15464sebastienros wants to merge 3 commits intomicrosoft:mainfrom
sebastienros wants to merge 3 commits intomicrosoft:mainfrom
Conversation
- Disabled: KustoEmulator_Starts - Disabled: KustoEmulator_WithDatabase_CanReadIngestedData - Disabled: KustoEmulator_WithDatabaseThatAlreadyExists_ErrorIsIgnored - Disabled: KustoEmulator_WithInvalidDatabase_LogsErrorAndContinues - Disabled: KustoEmulator_WithBindMount_IsUsedForPersistence - Issue: microsoft#11820 These tests are being disabled on Linux while the Kusto emulator image fails to start due to unsupported CPU instruction set requirements. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Preserved: KustoEmulator_Starts on AzDO - Preserved: KustoEmulator_WithDatabase_CanReadIngestedData on AzDO - Preserved: KustoEmulator_WithDatabaseThatAlreadyExists_ErrorIsIgnored on AzDO - Preserved: KustoEmulator_WithInvalidDatabase_LogsErrorAndContinues on AzDO - Preserved: KustoEmulator_WithBindMount_IsUsedForPersistence on AzDO - Issue: microsoft#11820 This keeps the existing Azure DevOps skip while also retaining the new Linux-targeted skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Linked: KustoEmulator_Starts Linux skip to microsoft#15463 - Linked: KustoEmulator_WithDatabase_CanReadIngestedData Linux skip to microsoft#15463 - Linked: KustoEmulator_WithDatabaseThatAlreadyExists_ErrorIsIgnored Linux skip to microsoft#15463 - Linked: KustoEmulator_WithInvalidDatabase_LogsErrorAndContinues Linux skip to microsoft#15463 - Linked: KustoEmulator_WithBindMount_IsUsedForPersistence Linux skip to microsoft#15463 This keeps the existing Azure DevOps disable on issue microsoft#11820 and moves the Linux-only disable to the dedicated Kusto emulator issue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15464Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15464" |
Comment on lines
41
to
45
| [Fact] | ||
| [RequiresFeature(TestFeature.Docker)] | ||
| [ActiveIssue("https://github.com/microsoft/aspire/issues/11820", typeof(PlatformDetection), nameof(PlatformDetection.IsRunningFromAzdo))] | ||
| [ActiveIssue("https://github.com/microsoft/aspire/issues/15463", typeof(PlatformDetection), nameof(PlatformDetection.IsLinux))] | ||
| public async Task KustoEmulator_Starts() |
There was a problem hiding this comment.
These two ActiveIssue attributes are repeated on every test in this class. Since ActiveIssue is already used at class scope elsewhere in the repo, consider moving both skips to the KustoFunctionalTests class declaration to avoid duplication and ensure any future emulator-backed tests in this class inherit the same quarantine.
Also, the root cause in #15463 is missing SSE4.2/AVX2 on some Linux hosts; skipping on IsLinux disables the tests even on Linux machines that do support those instructions. If the intent is primarily to unblock CI, consider narrowing the condition (e.g., Linux + CI, or a PlatformDetection helper that checks CPU feature support) so local Linux/dev coverage can still run where possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily disables the Linux-targeted Kusto emulator functional tests in
tests/Aspire.Hosting.Azure.Kusto.Tests/KustoFunctionalTests.cswhile preserving the existing Azure DevOps skip.The current Kusto emulator image fails to start on Linux CI because it exits with an unsupported CPU instruction set error (
SSE4.2/AVX2), which causes the emulator-backed tests to fail before they can become healthy.Addresses #15463
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue:Validation
KustoFunctionalTeststests/Aspire.Hosting.Azure.Kusto.Tests/Aspire.Hosting.Azure.Kusto.Tests.csprojsuccessfully after updating theActiveIssueattributes#11820and added a Linux-targeted disable on#15463