Revert RUSTFLAGS env var leak workaround in build.yaml#60
Draft
Revert RUSTFLAGS env var leak workaround in build.yaml#60
Conversation
Agent-Logs-Url: https://github.com/microsoft/Windows-rust-driver-samples/sessions/3ae43aa9-af5f-43ce-8cb7-6bc9ac5342cb Co-authored-by: wmmc88 <16629657+wmmc88@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wmmc88
March 28, 2026 00:38
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the temporary
RUSTFLAGSenvironment variable workaround in thecargo makebuild step of.github/workflows/build.yaml.Changes
Removed:
$env:RUSTFLAGS = $nullline that unsetRUSTFLAGSbefore runningcargo makeshell: pwshdirective (no longer needed with a single-linerun)Restored the step to a simple single-line command:
Context
The workaround was introduced in #49 to prevent
RUSTFLAGS(specifically-D warnings) from leaking intorust-scriptcompilation ofwdk-build(a path dependency via symlink that defeats--cap-lints). The upstream fix is tracked at microsoft/windows-drivers-rs#629.