Modify System_Requests_C report to account for # of CPU on the system

[PiJoCoder]

No description provided.

[Copilot]

Pull request overview

Updates the System_Requests_C SSRS report definition to normalize reported CPU utilization by the system’s CPU core count, and adjusts report text/formatting to reflect the new meaning of “CPU %”.

Changes:

• Added core-count lookup logic and normalized cpu_percent calculations by dividing by core count.
• Updated report titles/labels/prompts and numeric formats to indicate normalized CPU%.
• Added a report footer/info row to display CPU core count.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File	Description
sqlnexus/Reports/System_Requests_C.rdlC	Normalizes CPU% by core count, updates UI text/formatting, and adds core-count display.
NexusReports/System_Requests_C.rdl	Same report updates mirrored in the report project output.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

elapsed_ms is computed via DATEDIFF_BIG(ms, ...) (bigint) and returned as delta_elapse_time. The RDL field for delta_elapse_time is still typed as System.Int32 (from the previous DATEDIFF(ms, ...)), which can overflow/truncate for larger gaps and cause render errors. Either cast elapsed_ms back to int or update the field type to System.Int64.

[Copilot]

The command-threshold filter groups only by c2.command but computes CPU% using SUM(delta_cpu) / AVG(elapsed_ms). Over a multi-row time range this inflates CPU% roughly by the number of samples (since SUM/AVG scales with row count) and can cause incorrect filtering/ordering. Use a time-weighted denominator (e.g., SUM(elapsed_ms)) or reintroduce the prior grouping by (command, runtime) if the intent is per-sample thresholding.

Suggested change

	/ NULLIF(AVG(CONVERT(float, c2.elapsed_ms)), 0)
	/ NULLIF(SUM(CONVERT(float, c2.elapsed_ms)), 0)

[Copilot]

The label CPU Core Count includes trailing spaces, which will render as extra padding/odd text in the report. Remove the trailing spaces from the textbox value.

Suggested change

	<Value>CPU Core Count </Value>
	<Value>CPU Core Count</Value>

[Copilot]

DataSet_CoreCount appears to be unused (no other part of the report references it). This adds an extra query and duplicates the core-count logic already embedded in DataSet_System_Threads_Stats. Remove this dataset or wire the report to use it.

Suggested change

	<DataSet Name="DataSet_CoreCount">
	<Query>
	<DataSourceName>DataSource1</DataSourceName>
	<CommandText>
	DECLARE @CoreCount INT = 1;
	SELECT @CoreCount = COALESCE(
	(SELECT CAST(PropertyValue AS INT) FROM [dbo].[tbl_ServerProperties] WHERE PropertyName = 'cpu_count'),
	(SELECT MAX(cpu_count) FROM [dbo].[tbl_dm_os_sys_info]),
	1
	);
	SELECT @CoreCount AS CoreCount;
	</CommandText>
	</Query>
	<Fields>
	<Field Name="CoreCount">
	<DataField>CoreCount</DataField>
	<rd:TypeName>System.Int32</rd:TypeName>
	</Field>
	</Fields>
	</DataSet>

[Copilot]

The label CPU Core Count includes trailing spaces, which will render as extra padding/odd text in the report. Remove the trailing spaces from the textbox value.

Suggested change

	<Value>CPU Core Count </Value>
	<Value>CPU Core Count</Value>

[Copilot]

elapsed_ms is computed via DATEDIFF_BIG(ms, ...) (bigint) and returned as delta_elapse_time. The RDL field for delta_elapse_time is still typed as System.Int32 (from the previous DATEDIFF(ms, ...)), which can overflow/truncate for larger gaps and cause render errors. Either cast elapsed_ms back to int or update the field type to System.Int64.

[Copilot]

DataSet_CoreCount appears to be unused (no other part of the report references it). This adds an extra query and duplicates the core-count logic already embedded in DataSet_System_Threads_Stats. Remove this dataset or wire the report to use it.

Suggested change

	<DataSet Name="DataSet_CoreCount">
	<Query>
	<DataSourceName>DataSource1</DataSourceName>
	<CommandText>
	DECLARE @CoreCount INT = 1;
	SELECT @CoreCount = COALESCE(
	(SELECT CAST(PropertyValue AS INT) FROM [dbo].[tbl_ServerProperties] WHERE PropertyName = 'cpu_count'),
	(SELECT MAX(cpu_count) FROM [dbo].[tbl_dm_os_sys_info]),
	1
	);
	SELECT @CoreCount AS CoreCount;
	</CommandText>
	</Query>
	<Fields>
	<Field Name="CoreCount">
	<DataField>CoreCount</DataField>
	<rd:TypeName>System.Int32</rd:TypeName>
	</Field>
	</Fields>
	</DataSet>

[Copilot]

The command-threshold filter groups only by c2.command but computes CPU% using SUM(delta_cpu) / AVG(elapsed_ms). Over a multi-row time range this inflates CPU% roughly by the number of samples (since SUM/AVG scales with row count) and can cause incorrect filtering/ordering. Use a time-weighted denominator (e.g., SUM(elapsed_ms)) or reintroduce the prior grouping by (command, runtime) if the intent is per-sample thresholding.

Suggested change

	/ NULLIF(AVG(CONVERT(float, c2.elapsed_ms)), 0)
	/ NULLIF(SUM(CONVERT(float, c2.elapsed_ms)), 0)