Conversation
…with SQL Nexus prebuild process and naming conventions
Collaborator
Author
|
related to #478 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ReadTrace report drillthrough targets to match the renamed *_C report filenames so report-to-report navigation works again across the packaged (sqlnexus/Reports/*.rdlC) and source (NexusReports/*.rdl) report sets.
Changes:
- Update multiple ReadTrace reports’
<Drillthrough><ReportName>values to reference the renamed*_Creport names. - Add ReadTrace reports to
NexusReports.rptprojso they’re included in the SSRS project. - Minor reordering of
ReadTrace_Main_C.rdlCcontent inclusion insqlnexus.csproj.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sqlnexus/sqlnexus.csproj | Reorders/ensures ReadTrace_Main_C.rdlC is included as content copied to output. |
| sqlnexus/Reports/ReadTrace_UniqueStmtTopN_C.rdlC | Fixes drillthrough target to ReadTrace_UniqueStmtDetails_C. |
| sqlnexus/Reports/ReadTrace_UniqueBatchTopN_C.rdlC | Fixes drillthrough target to ReadTrace_UniqueBatchDetails_C. |
| sqlnexus/Reports/ReadTrace_UniqueBatchDetails_C.rdlC | Fixes drillthrough target to ReadTrace_UniqueStmtDetails_C. |
| sqlnexus/Reports/ReadTrace_Main_C.rdlC | Fixes multiple drillthrough targets to *_C report names. |
| sqlnexus/Reports/ReadTrace_InterestingEvents_C.rdlC | Updates drillthrough targets to *_C report names (including self-drillthrough). |
| sqlnexus/Reports/ReadTrace_Grouping_C.rdlC | Updates drillthrough targets to *_C report names. |
| NexusReports/ReadTrace_UniqueStmtTopN_C.rdl | Mirrors drillthrough fix to ReadTrace_UniqueStmtDetails_C in source RDL. |
| NexusReports/ReadTrace_UniqueBatchTopN_C.rdl | Mirrors drillthrough fix to ReadTrace_UniqueBatchDetails_C in source RDL. |
| NexusReports/ReadTrace_UniqueBatchDetails_C.rdl | Mirrors drillthrough fix to ReadTrace_UniqueStmtDetails_C in source RDL. |
| NexusReports/ReadTrace_Main_C.rdl | Mirrors multiple drillthrough target updates to *_C report names in source RDL. |
| NexusReports/ReadTrace_InterestingEvents_C.rdl | Mirrors drillthrough target updates to *_C report names in source RDL. |
| NexusReports/ReadTrace_Grouping_C.rdl | Mirrors drillthrough target updates to *_C report names in source RDL. |
| NexusReports/NexusReports.rptproj | Adds ReadTrace reports to the SSRS project’s report list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hacitandogan
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test: