feat(canary-web-components): enable links in date cells for data table#4377
Open
feat(canary-web-components): enable links in date cells for data table#4377
Conversation
Contributor
|
View your canary branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3827-allow-data-table-cells-with-date-type-to-be-a-link/canary-web-components |
Contributor
|
Cypress visual tests failed. |
c4ed95e to
ed3901b
Compare
Allow date objectswith href properties to render as links in the data table
ed3901b to
a9b11f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow date objectswith href properties to render as links in the data table
Provide a "datetime" type for data table cells
Summary of the changes
Adds support for a "datetime" column type, ensures consistent date/time formatting, and allows links in date/datetime cells for the data table component.
Related issue
#3827
#3828
Checklist
General
Testing