fix: align faas runner detection with protocol and validate runners#105
Open
Ishita-190 wants to merge 3 commits intometacall:masterfrom
Open
fix: align faas runner detection with protocol and validate runners#105Ishita-190 wants to merge 3 commits intometacall:masterfrom
Ishita-190 wants to merge 3 commits intometacall:masterfrom
Conversation
HeeManSu
reviewed
Mar 1, 2026
| for (const [runner, deps] of Object.entries(runnerDeps)) { | ||
| const command = installCommand[runner]; | ||
| for (const runner of resource.runners) { | ||
| const command = Runners[runner].installCommand; |
Contributor
There was a problem hiding this comment.
These are the correct installCommand.
python: 'metacall pip3 install -r requirements.txt',
nodejs: 'metacall npm i',
ruby: 'metacall bundle install',
csharp: 'metacall dotnet restore && metacall dotnet release'
But, i don't see metacall prefix in the protocol.
https://github.com/metacall/protocol/blob/master/src/language.ts#L21
Also, csharp installCommand is incomplete.
https://github.com/metacall/protocol/blob/master/src/language.ts#L47
Any reason you skipped metacall ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes made to centralize runner metadata, improve type safety, and add validation for multipart runner inputs while keeping behavior consistent with protocol.
Related issue
#104
and metacall/protocol#41
Type of change
How to test
Steps to reproduce or verify the change locally:
npm ci(or equivalent)npm testand any additional verification stepsChecklist