fix: compare full origin (scheme+host+port) in is_same_site#1363
Merged
richard-to merged 2 commits intomainfrom Mar 15, 2026
Merged
fix: compare full origin (scheme+host+port) in is_same_site#1363richard-to merged 2 commits intomainfrom
richard-to merged 2 commits intomainfrom
Conversation
Previously is_same_site only compared hostnames, so requests from a different port on the same host (e.g. localhost:8080 vs localhost:32123) would incorrectly pass the CSRF check. Now all three components of the origin are compared. https://claude.ai/code/session_01JXV99vPFFRVeX3cst7SLTw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously is_same_site only compared hostnames, so requests from a different port on the same host (e.g. localhost:8080 vs localhost:32123) would incorrectly pass the CSRF check. Now all three components of the origin are compared.
https://claude.ai/code/session_01JXV99vPFFRVeX3cst7SLTw